Fixes #12266: Handle last RPM sort for more than 10 bootstrap RPMs #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old method of sorting used string based comparisons which after 10 release versions fails to sort properly. This moves to a method of comparing individual releases via integer comparison to derive the latest boostrap RPM.
| {'release' => release, 'rpm' => rpm} | ||
| end | ||
|
|
||
| rpms.sort { |a,b| a['release'].to_i <=> b['release'].to_i }.last |
There was a problem hiding this comment.
Does the RPM version never change, always 1.0? Could that change some day?
The last RPM ends up as 1.0.11 when we have:
["foo-1.0-1.noarch.rpm", "foo-2.0-2.noarch.rpm", "foo-1.0-11.noarch.rpm"]There was a problem hiding this comment.
AFAIK we don't increment the version (https://github.com/Katello/puppet-certs/pull/83/files/e6df6f10f485e0bf283c428c371fa2606b7faaa5#diff-d7c04bc14bf477574cb5d1f4d285675cR13) only the release when we generate a new bootstrap RPM. So possible that logic could change down the road, but I don't forsee it :)
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old method of sorting used string based comparisons which after 10
release versions fails to sort properly. This moves to a method of
comparing individual releases via integer comparison to derive the
latest boostrap RPM.